AT Proof-Of-Possession #2: Handle proof-of-possession tokens correctly in responses #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 14, 2020 18:26
pkanher617
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
sameerag,
hectormmg and
tnorling
as code owners
github-actions
bot
added
msal-common
jo-arroyo
approved these changes
Aug 17, 2020
tnorling
requested changes
Aug 17, 2020
jasonnutter
reviewed
Aug 18, 2020
tnorling
approved these changes
Aug 18, 2020
sangonzal
reviewed
Aug 18, 2020
| @@ -34,12 +34,10 @@ export class RefreshTokenClient extends BaseClient { | |||
| ); | |||
|
|
|||
| responseHandler.validateTokenResponse(response.body); | |||
| const tokenResponse = responseHandler.handleServerTokenResponse( | |||
| return await responseHandler.handleServerTokenResponse( | |||
There was a problem hiding this comment.
Should this also pass in request.resourceRequestMethod and request.resourceRequestUri given that they were added to RefreshTokenRequest?
There was a problem hiding this comment.
I've handled this in a later PR, this PR only covers the authorization code 2 legged flow, not the refresh flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to PR #2151, and implements the response handling part of the proof-of-possession flow in msal-common.
This PR specifically adds the following: