Skip to content

msal-react #1: account changes #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 19, 2020
Merged

msal-react #1: account changes #2356

merged 13 commits into from
Oct 19, 2020

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Sep 29, 2020 •
edited
Loading

  • Adds a stubbed instance of PCA to msal-browser which will throw if any APIs are invoked. This is used as the default instance for the react context and can be used in other framework libraries
  • Updates useIsAuthenticated hook to accept an AccountIdentifiers object and call getAccountByHomeId if homeAccountId is provided
  • Removes the [] fallback when calling getAllAccounts in msal-react as msal-browser was previously updated to return an empty array instead of null

@tnorling tnorling added the msal-react Related to @azure/msal-react label Sep 29, 2020
@tnorling tnorling added the work-in-progress Issue or PR is not finished. label Sep 29, 2020
@tnorling tnorling added this to the @azure/[email protected] milestone Oct 8, 2020
@tnorling tnorling removed the work-in-progress Issue or PR is not finished. label Oct 12, 2020
@github-actions github-actions bot added the msal-browser Related to msal-browser package label Oct 12, 2020
@tnorling tnorling marked this pull request as ready for review October 12, 2020 21:48
@tnorling tnorling changed the title msal-react account changes msal-react #1: account changes Oct 12, 2020
@tnorling tnorling merged commit bda2451 into msal-react-feature-branch Oct 19, 2020
@tnorling tnorling deleted the msal-react-account branch October 22, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter left review comments

@pkanher617 pkanher617 pkanher617 approved these changes

@jmckennon jmckennon jmckennon approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@hectormmg hectormmg Awaiting requested review from hectormmg

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo

@sameerag sameerag Awaiting requested review from sameerag

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-react Related to @azure/msal-react
Projects
None yet
Milestone
@azure/[email protected]
Development

Successfully merging this pull request may close these issues.
4 participants
@tnorling @jasonnutter @pkanher617 @jmckennon