Skip to content

msal-react #2: Login handler #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 21, 2020
Merged

msal-react #2: Login handler #2369

merged 23 commits into from
Oct 21, 2020

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Oct 1, 2020 •
edited
Loading

  • Updates useMsalAuthentication hook to accept an interactionType and request object to trigger login if user is not already authenticated
  • useHandleRedirect hook returns a tuple of [response, error]
  • Replaces wrapped msal instance with event callbacks

@tnorling tnorling added msal-react Related to @azure/msal-react work-in-progress Issue or PR is not finished. labels Oct 1, 2020
jasonnutter
jasonnutter reviewed Oct 1, 2020
View reviewed changes
jasonnutter
jasonnutter reviewed Oct 1, 2020
View reviewed changes
@github-actions github-actions bot added the msal-browser Related to msal-browser package label Oct 1, 2020
jamiehaywood
jamiehaywood reviewed Oct 8, 2020
View reviewed changes
jasonnutter
jasonnutter reviewed Oct 8, 2020
View reviewed changes
@tnorling tnorling added this to the @azure/[email protected] milestone Oct 8, 2020
@tnorling tnorling changed the base branch from msal-react-feature-branch to msal-react-account October 12, 2020 22:03
@tnorling tnorling changed the title msal-react Login handler msal-react #2: Login handler Oct 12, 2020
@tnorling tnorling removed the work-in-progress Issue or PR is not finished. label Oct 12, 2020
@tnorling tnorling marked this pull request as ready for review October 12, 2020 22:44
jamiehaywood
jamiehaywood reviewed Oct 14, 2020
View reviewed changes
jmckennon
jmckennon approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@jmckennon jmckennon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments but looks good!

@tnorling tnorling changed the base branch from msal-react-account to msal-react-feature-branch October 19, 2020 20:05
@tnorling tnorling removed the msal-browser Related to msal-browser package label Oct 19, 2020
@github-actions github-actions bot added the msal-browser Related to msal-browser package label Oct 20, 2020
jasonnutter
jasonnutter reviewed Oct 21, 2020
View reviewed changes
jasonnutter
jasonnutter approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing otherwise looks good!

tnorling
tnorling commented Oct 21, 2020
View reviewed changes
@tnorling tnorling merged commit b8e46d1 into msal-react-feature-branch Oct 21, 2020
@tnorling tnorling deleted the msal-react-login-handler branch October 22, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehaywood jamiehaywood jamiehaywood left review comments

@jasonnutter jasonnutter jasonnutter approved these changes

@jmckennon jmckennon jmckennon approved these changes

@pkanher617 pkanher617 Awaiting requested review from pkanher617

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@hectormmg hectormmg Awaiting requested review from hectormmg

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo

@sameerag sameerag Awaiting requested review from sameerag

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-react Related to @azure/msal-react
Projects
None yet
Milestone
@azure/[email protected]
Development

Successfully merging this pull request may close these issues.
4 participants
@tnorling @jasonnutter @jmckennon @jamiehaywood