Breaking out a custom StorageProvider option + misc Cleanup #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 19, 2018 15:46
… front and store the cache object if it succeeds. Fixed some bugs in the existing checking. Added support for caching static instances based on cache location, since the previous implementation would have incorrect behavior if run twice with different cache locations (probably doesn't matter under normal usage, but correctness...) Broke out an exported interface UserAgentApplication options types for easier client coding. Broke out a StorageProvider interface from the Storage class implementation, and added support in the UAA options class for providing a custom storage provider implementation for more complicated clients to use.
…e a while, so need to use this as a fork of the codebase for potentially a few months.
|
Note: I pulled dist files into here so I can use this branch as a public release fork of msal. Basically just look at commit #1 for the content of the actual changes. |
added 2 commits
June 28, 2018 13:44
|
Will reopen with a simpler implementation to try to get into master sooner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the Storage class to do all of the appropriate checking up front and store the cache object if it succeeds. Fixed some bugs in the existing checking. Added support for caching static instances based on cache location, since the previous implementation would have incorrect behavior if run twice with different cache locations (probably doesn't matter under normal usage, but correctness...) Broke out an exported interface UserAgentApplication options type for easier client coding. Broke out a StorageProvider interface from the Storage class implementation, and added support in the UAA options class for providing a custom storage provider implementation for more complicated clients to use.