Skip to content

Basic token validation implementation #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 98 commits into from
Mar 4, 2022
Merged

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented Jan 5, 2022

Basic implementation of token validation for the @azure/node-token-validation library, to replace passport-azure-ad.

This PR includes:

  • Node-token-validation library with basic implementation of token validation:
    • JWT parsing
    • JWT type check
    • JWT signature check
    • JWT claims check
  • A simple Node sample that calls the validateToken API (other public APIs will be added in another PR)

Due to the length of this PR, and given that implementation is incremental, the following will be included in separate PRs:

  • Unit tests
  • Additional public APIs
  • Updated response type
  • Updated metadata refresh handling
  • Documentation

More detail can be found in the initial design spec. I will be writing additional design specs to address:

  • Configuration and TokenValidationParameters
  • Public APIs
  • Metadata and resiliency

@github-actions github-actions bot added documentation Related to documentation. samples Related to the samples apps for the library. labels Jan 5, 2022
@github-actions github-actions bot added the extensions Related to extensions for the base libraries label Mar 1, 2022
@github-actions github-actions bot removed the extensions Related to extensions for the base libraries label Mar 1, 2022
@github-actions github-actions bot added the extensions Related to extensions for the base libraries label Mar 3, 2022
@github-actions github-actions bot removed the extensions Related to extensions for the base libraries label Mar 3, 2022
@jasonnutter
Copy link
Contributor

Might be good to squash these commits when merging (should be an option from teh dropdown). Thanks for addressing feedback, great job so far!

@jo-arroyo jo-arroyo merged commit 856d081 into dev Mar 4, 2022
@jo-arroyo jo-arroyo deleted the token-validation-feature-build branch March 4, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. node-token-validation samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants