Skip to content

Refactor RequestParameterBuilder (EAR Pre-Req #1) #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 12, 2025
Merged

Refactor RequestParameterBuilder (EAR Pre-Req #1) #7621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4e0640c
refactor RequestParameterBuilder
tnorling Mar 7, 2025
fadb3e1
restore broker param instrumentation
tnorling Mar 7, 2025
bbefb65
tests
tnorling Mar 7, 2025
729df91
Change files
tnorling Mar 7, 2025
4f2b4f8
lint
tnorling Mar 8, 2025
11ef5c3
Merge branch 'dev' into refactor-request-generation
tnorling Mar 11, 2025
20172a6
update tests
tnorling Mar 11, 2025
5317fe2
formatting
tnorling Mar 11, 2025
2e496f2
Fix failing test
tnorling Mar 12, 2025
1566554
format
tnorling Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@azure-msal-browser-fac3c638-31fb-4b30-bca8-dcba43a3e70a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "refactor RequestParameterBuilder",
"packageName": "@azure/msal-browser",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@azure-msal-common-8ac1af0a-9ef9-4ee0-be7f-6b1d9de8d169.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "refactor RequestParameterBuilder",
"packageName": "@azure/msal-common",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@azure-msal-node-8304ae25-1718-4f95-8511-303fb19fa240.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "refactor RequestParameterBuilder",
"packageName": "@azure/msal-node",
"email": "[email protected]",
"dependentChangeType": "patch"
}
3 changes: 1 addition & 2 deletions lib/msal-browser/src/naa/mapping/NestedAppAuthAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ export class NestedAppAuthAdapter {

const correlationId =
request.correlationId || this.crypto.createNewGuid();
const requestBuilder = new RequestParameterBuilder(correlationId);
const claims = requestBuilder.addClientCapabilitiesToClaims(
const claims = RequestParameterBuilder.addClientCapabilitiesToClaims(
request.claims,
this.clientCapabilities
);
Expand Down
435 changes: 334 additions & 101 deletions lib/msal-common/apiReview/msal-common.api.md
View file
Open in desktop

Large diffs are not rendered by default.

Loading