Skip to content

Redirect flow temporary cache refactor #7648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 66 commits into from
Mar 24, 2025
Merged

Conversation

tnorling
Copy link
Collaborator

This PR makes several changes to temporary cache used in the redirect flow to prepare for the addition of the EAR protocol and has the added benefit of consolidating response handling across flows (more work to be done here but that's a tomorrow problem)

  • Cache the full request + verifier rather than prebuilding the AuthCodeRequest before redirecting.
  • Stop caching nonce, state, correlationId and authority separately as they will be included in the full request above ^
  • Stop caching CCSCredential as everything needed to build it is in the full request above ^
  • Move temporary storage cleanup (including interaction_in_progress) to more centralized locations

tnorling added 30 commits March 7, 2025 10:08
@github-actions github-actions bot added the documentation Related to documentation. label Mar 18, 2025
Base automatically changed from ear-protocol to dev March 24, 2025 21:30
@tnorling tnorling requested review from a team and Robbie-Microsoft as code owners March 24, 2025 21:30
@tnorling tnorling requested a review from bgavrilMS as a code owner March 24, 2025 22:45
@tnorling tnorling enabled auto-merge (squash) March 24, 2025 22:47
@tnorling tnorling merged commit 3f96e7f into dev Mar 24, 2025
7 checks passed
@tnorling tnorling deleted the redirect-request-cache-refactor branch March 24, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-browser Related to msal-browser package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants