Skip to content

[v5] Changes to Configuration - BrowserAuthOptions (Config #1) #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 16, 2025
Merged

[v5] Changes to Configuration - BrowserAuthOptions (Config #1) #7695

merged 16 commits into from
Apr 16, 2025

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented Apr 11, 2025 •
edited
Loading

This PR updates the BrowserAuthOptions for MSAL Browser v5, including:

  • Removal of references, implementations, and tests for skipAuthorityMetadataCache
  • Moves protocolMode to SystemOptions
  • Removal of documentation references to supportsNestedAppAuth

@github-actions github-actions bot added documentation Related to documentation. msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library. msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-react Related to @azure/msal-react labels Apr 11, 2025
@jo-arroyo jo-arroyo changed the base branch from dev to msal-v5 April 11, 2025 19:20
@github-actions github-actions bot removed msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library. msal-react Related to @azure/msal-react labels Apr 11, 2025
@jo-arroyo jo-arroyo changed the title [v5] Changes to Configuration [v5] Changes to Configuration - BrowserAuthOptions Apr 12, 2025
@jo-arroyo jo-arroyo marked this pull request as ready for review April 14, 2025 17:00
@jo-arroyo jo-arroyo requested a review from shylasummers as a code owner April 14, 2025 17:00
@jo-arroyo jo-arroyo changed the title [v5] Changes to Configuration - BrowserAuthOptions [v5] Changes to Configuration - BrowserAuthOptions (Config #1) Apr 14, 2025
@jo-arroyo jo-arroyo merged commit 8a3036c into msal-v5 Apr 16, 2025
8 checks passed
@jo-arroyo jo-arroyo deleted the config-change-base branch April 16, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectormmg hectormmg hectormmg approved these changes

@shylasummers shylasummers shylasummers approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jo-arroyo @hectormmg @shylasummers