Skip to content

Fix for issue #3: Implement Telemetry public API surface #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2017
Merged

Fix for issue #3: Implement Telemetry public API surface #8

merged 2 commits into from
Apr 5, 2017

Conversation

shivbijlani
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Apr 5, 2017

@shivbijlani,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@shivbijlani shivbijlani closed this Apr 5, 2017
@shivbijlani shivbijlani reopened this Apr 5, 2017
@msftclas
Copy link

msftclas commented Apr 5, 2017

@shivbijlani,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@shivbijlani shivbijlani requested a review from kpanwar April 5, 2017 05:28
kpanwar
kpanwar approved these changes Apr 5, 2017
View reviewed changes
lib/Telemetry.ts Outdated
@@ -0,0 +1,17 @@
namespace MSAL {
class Telmetry {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling.

lib/Telemetry.ts Outdated
this.receiverCallback = receiverCallback;
}

static GetInstance(): Telmetry {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling.

@shivbijlani shivbijlani merged commit 96dd207 into dev Apr 5, 2017
@shivbijlani shivbijlani deleted the shivb/3-telemetry_public branch April 5, 2017 16:01
@shivbijlani
Copy link
Contributor Author

This is how the sample app can use telemetry: @rohitnarula7176

app.js:

var telemetry = MSAL.Telemetry.GetInstance();
telemetry.RegisterReceiver(function (data) {
console.log("Received event :" + JSON.stringify(data));
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpanwar kpanwar kpanwar approved these changes

@rohitnarula7176 rohitnarula7176 Awaiting requested review from rohitnarula7176

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivbijlani @msftclas @kpanwar