Skip to content

Return the floor if available on iOS #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Return the floor if available on iOS #576

merged 3 commits into from
Nov 3, 2020

Conversation

mvanbeusekom
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature

⤵️ What is the current behavior?

iOS has the option to return the floor on which the device is located when this is supported by the WiFi network. At the moment this information is not returned by the Geolocator.

🆕 What is the new behavior (if this is a feature change)?

The geolocator will now return the floor as part of the Position object when requesting location information when this information is available (only on iOS and only if the information is available, otherwise it will return null).

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@mvanbeusekom mvanbeusekom added this to the geolocator_v6.1.4 milestone Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #576 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #576   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          257       257           
=========================================
  Hits           257       257           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14718d8...4d238a0. Read the comment docs.

@mvanbeusekom mvanbeusekom merged commit 93e678c into master Nov 3, 2020
@mvanbeusekom mvanbeusekom deleted the issue/562 branch November 3, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for floor indication (iOS only)
1 participant