Remove original positionStream when new positionStream is initialized #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florissmit1
changed the title
# Conflicts: # geolocator_platform_interface/CHANGELOG.md # geolocator_platform_interface/pubspec.yaml
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 226 238 +12
=========================================
+ Hits 226 238 +12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
When initializing a new positionStream, after closing the previous positionStream, the given distanceFilter or/and timeInterval are not updated. The first positionStream will always be returned, even if a new positionStream is initialized.
🆕 What is the new behavior (if this is a feature change)?
When positionStream.cancel() is executed, the old positionStream will be deleted. So when initializing a new positionStream, the new positionStream is returned.
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
Initialize two positionStreams with different parameters (such as distanceFilter or timeInterval) and compare the results.
📝 Links to relevant issues/docs
[#703]
🤔 Checklist before submitting
master.