Updated platform interface to have recording methods return XFile instances #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
requested changes
Nov 12, 2020
| @@ -67,7 +68,7 @@ abstract class CameraPlatform extends PlatformInterface { | |||
| } | |||
|
|
|||
| /// Captures an image and saves it to [path]. | |||
There was a problem hiding this comment.
Would be good to update the documentation. Maybe something like:
Suggested change
| /// Captures an image and saves it to [path]. | |
| /// Captures an image and returns it as a `XFile`. |
| @@ -76,20 +78,19 @@ abstract class CameraPlatform extends PlatformInterface { | |||
| throw UnimplementedError('prepareForVideoRecording() is not implemented.'); | |||
| } | |||
|
|
|||
| /// Start a video recording and save the file to [path]. | |||
| /// Starts a video recording | |||
There was a problem hiding this comment.
nit: missing a . after the sentence:
Suggested change
| /// Starts a video recording | |
| /// Starts a video recording. |
| /// | ||
| /// A path can for example be obtained using | ||
| /// [path_provider](https://pub.dartlang.org/packages/path_provider). | ||
| /// If no [file] parameter is provided, the recording will be saved to a new file in a temporary location. |
There was a problem hiding this comment.
nit: wrap the documentation at 80 characters.
Suggested change
| /// If no [file] parameter is provided, the recording will be saved to a new file in a temporary location. | |
| /// If no [file] parameter is provided, the recording will be saved to a new | |
| /// file in a temporary location. |
Comment on lines
86
to
87
| /// If a file already exists at the path for the provided file instance, an error will be thrown. | ||
| /// The file can be read as soon as [stopVideoRecording] returns it. |
There was a problem hiding this comment.
nit: Wrap the documentation at 80 characters:
Suggested change
| /// If a file already exists at the path for the provided file instance, an error will be thrown. | |
| /// The file can be read as soon as [stopVideoRecording] returns it. | |
| /// If a file already exists at the path for the provided file instance, an | |
| /// error will be thrown. | |
| /// The file can be read as soon as [stopVideoRecording] returns it. |
mvanbeusekom
requested changes
Nov 13, 2020
packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart
Outdated
Show resolved
Hide resolved
packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart
Show resolved
Hide resolved
…erface/camera_platform.dart Co-authored-by: Maurits van Beusekom <[email protected]>
…erface/camera_platform.dart Co-authored-by: Maurits van Beusekom <[email protected]>
mvanbeusekom
approved these changes
Nov 13, 2020
mvanbeusekom
deleted the
subpr/camera_federated/platform-interface-xfile
branch
mvanbeusekom
restored the
subpr/camera_federated/platform-interface-xfile
branch
mvanbeusekom
deleted the
subpr/camera_federated/platform-interface-xfile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file_selector_platform_interfacedependency. To be changed later whencross_filePR is merged.