Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update perfect-scrollbar to ^1.5.1 to fix "Cannot read property 'scrollTop' of null" issue #68

Closed
MarkParnwell opened this issue Dec 10, 2021 · 6 comments

Comments

@MarkParnwell
Copy link

MarkParnwell commented Dec 10, 2021

We're encountering a lot of Cannot read property 'scrollTop' of null errors (https://github.com/mdbootstrap/perfect-scrollbar/issues/835).

This was fixed in perfect-scrollbar 1.5.1 (https://github.com/mdbootstrap/perfect-scrollbar/releases/tag/1.5.1), but looking at the /dist/ of 1.4.1 published on NPM, version 1.5.0 is still bundled (like here https://github.com/Binaryify/vue-custom-scrollbar/blob/master/dist/vueScrollbar.umd.min.js#L3).

Could we bump the perfect-scrollbar version, rebuild and publish?

Thank you

@Binaryify
Copy link
Owner

sure

Binaryify added a commit that referenced this issue Dec 10, 2021
Binaryify added a commit that referenced this issue Dec 10, 2021
@Binaryify
Copy link
Owner

please check v1.4.2~

@MarkParnwell
Copy link
Author

Unfortunately, it seems the distributables are still out of date on NPM and here... https://github.com/Binaryify/vue-custom-scrollbar/blob/master/dist/vueScrollbar.umd.min.js#L3
I think it needs a rebuild

@Binaryify
Copy link
Owner

wait

Binaryify added a commit that referenced this issue Dec 10, 2021
@Binaryify
Copy link
Owner

plz check v1.4.3

@MarkParnwell
Copy link
Author

Excellent! Seems to be updated now. Now showing v1.5.3. Thank you 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants