Code Quality Fixes(3) #1518
Merged
Code Quality Fixes(3) #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g1itch
reviewed
Sep 10, 2019
|
What a problem with flake8 in $ flake8 -v src/network/socks5.py
flake8.plugins.manager MainProcess 86 INFO Loading entry-points for "flake8.extension".
flake8.plugins.manager MainProcess 111 INFO Loading entry-points for "flake8.listen".
flake8.plugins.manager MainProcess 111 INFO Loading entry-points for "flake8.report".
flake8.plugins.manager MainProcess 112 INFO Loading plugin "C90" from entry-point.
flake8.plugins.manager MainProcess 117 INFO Loading plugin "pycodestyle.comparison_type" from entry-point.
flake8.plugins.manager MainProcess 124 INFO Loading plugin "pycodestyle.missing_whitespace_after_import_keyword" from entry-point.
flake8.plugins.manager MainProcess 124 INFO Loading plugin "pycodestyle.imports_on_separate_lines" from entry-point.
flake8.plugins.manager MainProcess 124 INFO Loading plugin "pycodestyle.continued_indentation" from entry-point.
flake8.plugins.manager MainProcess 125 INFO Loading plugin "pycodestyle.maximum_line_length" from entry-point.
flake8.plugins.manager MainProcess 125 INFO Loading plugin "pycodestyle.bare_except" from entry-point.
flake8.plugins.manager MainProcess 125 INFO Loading plugin "pycodestyle.ambiguous_identifier" from entry-point.
flake8.plugins.manager MainProcess 125 INFO Loading plugin "pycodestyle.python_3000_not_equal" from entry-point.
flake8.plugins.manager MainProcess 125 INFO Loading plugin "pycodestyle.trailing_whitespace" from entry-point.
flake8.plugins.manager MainProcess 125 INFO Loading plugin "F" from entry-point.
flake8.plugins.manager MainProcess 136 INFO Loading plugin "pycodestyle.whitespace_around_operator" from entry-point.
flake8.plugins.manager MainProcess 136 INFO Loading plugin "pycodestyle.python_3000_raise_comma" from entry-point.
flake8.plugins.manager MainProcess 136 INFO Loading plugin "pycodestyle.comparison_negative" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.python_3000_has_key" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.blank_lines" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.python_3000_backticks" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.indentation" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.tabs_or_spaces" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.module_imports_on_top_of_file" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.missing_whitespace" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.whitespace_around_named_parameter_equals" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.explicit_line_join" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.whitespace_around_comma" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.whitespace_before_parameters" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.missing_whitespace_around_operator" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.compound_statements" from entry-point.
flake8.plugins.manager MainProcess 137 INFO Loading plugin "pycodestyle.trailing_blank_lines" from entry-point.
flake8.plugins.manager MainProcess 138 INFO Loading plugin "pycodestyle.extraneous_whitespace" from entry-point.
flake8.plugins.manager MainProcess 138 INFO Loading plugin "pycodestyle.whitespace_around_keywords" from entry-point.
flake8.plugins.manager MainProcess 138 INFO Loading plugin "pycodestyle.tabs_obsolete" from entry-point.
flake8.plugins.manager MainProcess 138 INFO Loading plugin "pycodestyle.break_around_binary_operator" from entry-point.
flake8.plugins.manager MainProcess 138 INFO Loading plugin "pycodestyle.whitespace_before_comment" from entry-point.
flake8.plugins.manager MainProcess 138 INFO Loading plugin "pycodestyle.comparison_to_singleton" from entry-point.
flake8.plugins.manager MainProcess 138 INFO Loading plugin "default" from entry-point.
flake8.plugins.manager MainProcess 139 INFO Loading plugin "quiet-filename" from entry-point.
flake8.plugins.manager MainProcess 139 INFO Loading plugin "pylint" from entry-point.
flake8.plugins.manager MainProcess 139 INFO Loading plugin "quiet-nothing" from entry-point.
flake8.checker MainProcess 153 INFO Making checkers
flake8.checker MainProcess 159 INFO Checking 1 files
flake8.main.application MainProcess 351 INFO Finished running
flake8.main.application MainProcess 352 INFO Reporting errors
flake8.main.application MainProcess 353 INFO Found a total of 0 violations and reported 0Found a total of 0 violations and reported 0 |
|
W504 line break after binary operator |
|
Hate it 8( At first it warned about line break before binary operator (some versions keep warning). And now it turns out that the right way is to break before: https://bugs.python.org/issue26763 |
|
Okay, will try to ignore that warning from next time. |
lakshyacis
force-pushed
the
codefix1
branch
from
0a790d9 to
d5b766f
Compare
g1itch
reviewed
Sep 12, 2019
lakshyacis
force-pushed
the
codefix1
branch
2 times, most recently
from
b6e8d50 to
369bec4
Compare
PeterSurda
approved these changes
Sep 13, 2019
lakshyacis
force-pushed
the
codefix1
branch
from
369bec4 to
a961a4a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODE QUALITY FIXES
socks4a pylint fixes,
socks5 flake8 fixes,
stats flake8 fixes,
stats pylint fixes,
tls flake8 fixes,
tls pylint fixes,
udp pylint fixes,
networkthread pylint fixes,
node pylint fixes,
proxy pylint fixes.