Skip to content

Error handling improvements #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Error handling improvements #21

merged 4 commits into from
Apr 4, 2023

Conversation

PJColombo
Copy link
Member

No description provided.

@PJColombo PJColombo linked an issue Mar 28, 2023 that may be closed by this pull request
5 tasks
@PJColombo PJColombo marked this pull request as ready for review March 30, 2023 01:30
@PJColombo PJColombo force-pushed the error-handling-improvements branch from 2470ef8 to 0d23ed7 Compare March 30, 2023 01:48
Copy link
Member

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a high level review and I feel that I still need to go into more details of the code to have the full context on some of functionalities but overall looking good.

Ok(())
}

async fn process_slot_with_retry(&mut self, slot: u32) -> Result<()> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is cool to see how you use Arc<Mutex<>> for this problem 🎩

@0xGabi 0xGabi merged commit 6a7d6e2 into master Apr 4, 2023
@PJColombo PJColombo deleted the error-handling-improvements branch May 25, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling
2 participants