-
Notifications
You must be signed in to change notification settings - Fork 12
Add Parallel Indexing #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124b9fc
to
92867b4
Compare
92867b4
to
f884509
Compare
8141b50
to
1ed0d31
Compare
1ed0d31
to
d21a5f9
Compare
a4d7e25
to
d09e496
Compare
d09e496
to
40d9cbd
Compare
- Rollback slot retryer - Rename slot processor manager for better legibility - Move multiple slots processing logic out of the `SlotProcessor` - Implement `Display` trait for slots processor error
c943978
to
ba18f70
Compare
ba18f70
to
0aa7e29
Compare
f84bb0e
to
87f24c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I'll try it today
7fe9ac6
to
6013b40
Compare
…t processing logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It depends on the following API changes.
This PR introduces parallel indexing by dividing the slots to be processed into manageable chunks, each of which is handled by a dedicated indexing thread.
To enhance error resilience during large-scale slot processing, an initial division of slots is performed. Each chunk is then processed sequentially. This approach allows for frequent updates to the
latest slot
and mitigates the need for extensive rollbacks in the event of a failure.Additional modifications included in this PR:
Context
refactoring.Also, I attach the logs from a preliminary benchmark test, in which 1000 slots were indexed:
There's a substantial improvement in speed, performing approximately 11.52 times faster than the sequential approach.