Add Tooltip component #810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tooltip component Add basic portal component for tooltip Add tooltip component in navigator buttons Add tooltip for button components Add translation for button tooltip texts Add tooltip delay Show tooltip arrow on edges at correct location Fix tooltip arrow center position issue
Komediruzecki
force-pushed
the
feature/improve-tooltip-handling
branch
from
d4e9275 to
a2881c7
Compare
|
@Rokt33r we could use this code to improve cloud tooltips, when adding tooltip alongside edge of screen, the whole tooltip can not be viewed, Maybe I should rebase this PR and add improvements to shared tooltip component and merge this instead? |
|
Closing in favor of new local space only repository, will be reopened and rebased there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Tooltip component (#552)
Few examples of how it looks:
I left the coloring and styling to whoever can make it work and used tooltip background color available in the theme.
In this (blackish) color arrow is sometimes not seen so clearly and on a dark background, it would also be a bit harder to spot. Meaning separate colors for each theme (black/white/sepia) could be used, an example of that would be something like this:
The non-transparent color would also help I think.
Tested in