Skip to content

Debug spheres lab2 - LG #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Debug spheres lab2 - LG #17

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39a0993
Updated readme
siwel-cg Sep 18, 2024
0781792
Update readme more
siwel-cg Sep 18, 2024
d5575ba
More readme updates
siwel-cg Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
# lab02-debugging
# Lewis Ghrist : Aaron Jiang
Link: [Debug Spheres](https://www.shadertoy.com/view/XXlcWj)
# Bugs
Bug 1/2: Syntax error in the mainImage function causing complie error (line 98). The uv vector was both defined twice and jankily: (vec uv2). Fixed by just doing uv = . . .

# Setup
Bug 3: Scale issue with the camera (line 10), causing horizontal stretching. This was due to the horizontal value being assigned an inccorect value: H = len * iResolution.x / iResolution.x; Fix: H = len * iResolution.x / iResolution.y;

Create a [Shadertoy account](https://www.shadertoy.com/). Either fork this shadertoy, or create a new shadertoy and copy the code from the [Debugging Puzzle](https://www.shadertoy.com/view/flGfRc).
Bug 4: The ray march distance was too short (line 17). After only 64 steps, the background grid was not getting rendered. This also caused the floor under the spheres to look deformed. The fix was to increase the number of steps in our march to 256.

Let's practice debugging! We have a broken shader. It should produce output that looks like this:
[Unbelievably beautiful shader](https://user-images.githubusercontent.com/1758825/200729570-8e10a37a-345d-4aff-8eff-6baf54a32a40.webm)

It don't do that. Correct THREE of the FIVE bugs that are messing up the output. You are STRONGLY ENCOURAGED to work with a partner and pair program to force you to talk about your debugging thought process out loud.

Extra credit if you can find all FIVE bugs.

# Submission
- Create a pull request to this repository
- In the README, include the names of both your team members
- In the README, create a link to your shader toy solution with the bugs corrected
- In the README, describe each bug you found and include a sentence about HOW you found it.
- Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!)
Bug 5: The specular reflections were not working (line 72). This was due to the eye vector being reflected about the normal. What we want is the vector from the eye to the intersection point to be reflected: dir = reflect(dir, nor);