Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab2: Zhiyi Zhou #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,34 @@ Extra credit if you can find all FIVE bugs.
- In the README, create a link to your shader toy solution with the bugs corrected
- In the README, describe each bug you found and include a sentence about HOW you found it.
- Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!)

# Result
[shader link](https://www.shadertoy.com/view/M3ScWh)

## Bugs
- line 97
```
// wrong code
vec uv2 = 2.0 * uv - vec2(1.0);

// correct
uv = 2.0 * uv - vec2(1.0);
```

- In the raycast function Line 11
```
// wrong code
H *= len * iResolution.x / iResolution.x;

// correct
H *= len * iResolution.x / iResolution.y;
```

- Line 75
```
// wrong code
dir = reflect(eye, nor);

//correct
dir = reflect(dir, nor);
```