Skip to content

updated readme with lab info #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,17 @@ Extra credit if you can find all FIVE bugs.
- In the README, create a link to your shader toy solution with the bugs corrected
- In the README, describe each bug you found and include a sentence about HOW you found it.
- Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!)

# Team Names
- Jeffrey Mostyn
- Matt Schwartz

# Shadertoy
https://www.shadertoy.com/view/lXfcW2

# Bugs
1. uv2 was misdeclared as vec type. This was found from compiler error message
2. iResolution.x was being divided by itself, distorting the image horizontally. We traced this issue to this operation, which on inspection was clearly incorrect. Dividing by iResolution.y instead corrected the distortion
3. The center of the middle sphere was in the bottom left corner rather than the middle of the screen. This would have to be caused by an incorrect mapping of world to screen. We noticed that when we mapped the world to [-1, 1] space, that the resultant uv2 was not ever used. We passed this into the raycast function instead of uv, which is [0, 1] space
4. The rendering of the floor stopped shortly past the spheres, so we knew that we would need to either increase the step length or the number of steps to render things that were further into the scene. Changing the step length risks incorrect intersection calculations, so we increased the step count which fixed the problem.
5. Reflections did not render. In the intersection function, we noticed that the vector that was being reflected around the intersection normal was `eye` instead of the actual direciton of the raycast, `dir`. Switching the two fixed this bug