Skip to content

StringReader fails to normalize Windows line endings #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrennie opened this issue Jan 23, 2015 · 0 comments · Fixed by #145
Closed

StringReader fails to normalize Windows line endings #133

mrennie opened this issue Jan 23, 2015 · 0 comments · Fixed by #145

Comments

@mrennie
Copy link

mrennie commented Jan 23, 2015

StringReader has the following regex in it to try and normalize line endings:

this._input = text.replace(/\n\r?/g, "\n");

Which should probably be:

this._input = text.replace(/\r\n?/g, "\n");

nschonni added a commit that referenced this issue Apr 15, 2015
[Fix #133] StringReader fails to normalize Windows line endings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants