Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): handle the unnest table factor for the specific dialect #1104

Merged
merged 2 commits into from
Mar 28, 2025
Merged

fix(core): handle the unnest table factor for the specific dialect #1104

merged 2 commits into from
Mar 28, 2025

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Mar 25, 2025 •
edited by coderabbitai bot
Loading

Description

unnest_as_table_factor is required for the specific dialect only (e.g. BigQuery). We should enable it for BigQuery only.

Summary by CodeRabbit

  • New Features

    • Introduced support for a new SQL dialect, enhancing query generation rules specifically for BigQuery, particularly in handling array unnesting operations.
    • Added a new method to the WrenDialect implementation for improved functionality.

  • Tests

    • Added automated tests to validate SQL query transformations, ensuring accurate behavior in array unnesting scenarios across different data sources.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2025 •
edited
Loading

Walkthrough

The changes introduce a new method unnest_as_table_factor to the InnerDialect trait, which defaults to returning false. This method wraps functionality in the DataFusion SQL unparser dialect. The get_inner_dialect function is updated to handle DataSource::BigQuery, returning an instance of the BigQueryDialect struct, which overrides the unnest_as_table_factor method to return true. Additionally, a new asynchronous test function is added to validate SQL transformations using the UNNEST function with different data sources.

Changes

File(s) Changes
wren-core/core/src/mdl/dialect/inner_dialect.rs, wren-core/core/src/mdl/dialect/wren_dialect.rs Introduces a new BigQueryDialect implementing InnerDialect with an overridden unnest_as_table_factor (returns true). The WrenDialect now includes the unnest_as_table_factor method that delegates the call to its inner dialect. The get_inner_dialect function is updated to handle DataSource::BigQuery.
wren-core/core/src/mdl/mod.rs Adds an asynchronous test function, test_unnest_as_table_factor, which verifies the SQL output for an unnest query under both default and BigQuery data source configurations.

Sequence Diagram(s)

sequenceDiagram
    participant T as Test Client
    participant WD as WrenDialect
    participant ID as InnerDialect (BigQueryDialect)

    T->>WD: unnest_as_table_factor()
    WD->>ID: Delegate the call
    ID-->>WD: Return true (BigQuery-specific)
    WD-->>T: Return true
Loading 
sequenceDiagram
    participant Test as Async Test
    participant SC as SessionContext
    participant MB as ManifestBuilder
    participant SA as SQL Analyzer

    Test->>SC: Create session context
    Test->>MB: Build manifest (default & BigQuery)
    MB->>SA: Analyze manifest to generate SQL
    SA-->>Test: Return SQL query with proper unnest transformation
Loading

Suggested reviewers

  • douenergy

Poem

I'm a little rabbit with a coder's delight,
Hopping through dialects from morning to night.
BigQuery now sings with a custom SQL twist,
Unnesting tables, nothing gets missed!
Celebrating code changes with a joyful hop and a twist 🐇✨

Keep on hopping, my fellow devs!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14b63d8 and 6422a91.

📒 Files selected for processing (1)
  • wren-core/core/src/mdl/dialect/inner_dialect.rs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • wren-core/core/src/mdl/dialect/inner_dialect.rs
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: cargo test (win64)
  • GitHub Check: cargo test (macos-aarch64)
  • GitHub Check: cargo test (macos)
  • GitHub Check: cargo check
  • GitHub Check: ci
  • GitHub Check: test
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added core rust Pull requests that update Rust code labels Mar 25, 2025
goldmedal
goldmedal commented Mar 25, 2025
View reviewed changes
wren-core/core/src/mdl/mod.rs
let analyzed_mdl = Arc::new(AnalyzedWrenMDL::analyze(manifest)?);
let sql = "select * from unnest([1, 2, 3])";
let actual = transform_sql_with_ctx(&ctx, analyzed_mdl, &[], sql).await?;
assert_eq!(actual, "SELECT \"UNNEST(make_array(Int64(1),Int64(2),Int64(3)))\" FROM UNNEST([1, 2, 3])");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a valid SQL for BigQuery actually. See apache/datafusion#15233

@goldmedal goldmedal requested a review from douenergy March 25, 2025 06:49
douenergy
douenergy approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@douenergy douenergy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM , Thanks @goldmedal

@douenergy douenergy merged commit a03fd60 into Canner:main Mar 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douenergy douenergy douenergy approved these changes

Assignees
No one assigned
Labels
core rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldmedal @douenergy