If BadZipFile is raised we should catch it and raise a different exception instead #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| def test_malformed_docx_exception(): | ||
| with NamedTemporaryFile(suffix='.docx') as f: | ||
| try: | ||
| convert(f.name) |
There was a problem hiding this comment.
I would use raises for this. eg.
@raises(MalformedDocxException)
def test_malformed_docx_exception():
...
|
After a bit of documentation and maybe that test refactor, this looks good. |
jlward
added a commit
that referenced
this pull request
Jul 19, 2013
If BadZipFile is raised we should catch it and raise a different exception instead
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
If BadZipFile is raised we should catch it and raise a different exception instead
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
If BadZipFile is raised we should catch it and raise a different exception instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.