Fix incorrect computation of bounding boxes #841
Conversation
|
Thanks for the pull request @kring!
Reviewers, don't forget to make sure that:
|
kring
changed the title
|
After this is merged into ue5-main, post an update to https://community.cesium.com/t/linetrace-hit-detection-causing-value-to-be-world-origin/18478/3 to ask the user to check whether it fixes their problem as well. |
| FBoxSphereBounds result; | ||
| result.Origin = VecMath::createVector(center); | ||
| result.SphereRadius = sphereRadius; | ||
| result.BoxExtent = FVector(xs.GetAbsMax(), ys.GetAbsMax(), zs.GetAbsMax()); | ||
| result.BoxExtent = FVector(sphereRadius, sphereRadius, sphereRadius); |
There was a problem hiding this comment.
There's still a comment that says the sphere only has to reach the side of the box, is that still applicable / correct?
Also is all the stuff with the half-axes necessary in the BoundingSphere conversion, can't we just convert the sphere radius from meters to centimeters? Could we assume getTilesetToUnrealWorld is a rigid transform + a meters to centimeters scaling?
There was a problem hiding this comment.
I was trying to avoid making any assumptions about the transformation, since it's just a parameter to the method. So instead I construct a bounding box around the sphere, transform the box, and then build a sphere inset in the box. The comment is referring to the fact that the sphere only needs to be inset in the box, rather than fully contain it. There could very well be a better way to do this, but I think it works reasonably well.
|
@kring This seems to fix the issue and looks good to me! Only left one (probably unnecessary) comment, feel free to self-merge this otherwise. |
Fixes #839
I "improved" the bounding box computation in #823. It looked surprisingly right considering how actually wrong it was. 😆
Generally it worked ok near the georeference origin, but got very bad for tiles that are not well aligned to the Unreal axes.
I think it's correct now, but it would definitely be wise for someone to double-check my math when reviewing this!