-
Notifications
You must be signed in to change notification settings - Fork 49
Create an npm module for message cache #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this relevant? |
Maybe not. But, the message cache is it's own data structure just like the time cache is. The time cache is used throughout js-libp2p projects. I'm not sure if the message cache is as extensively used. |
I would suggest that if we create a new module that needs a message cache, we extract it from here to its own module. Until then, we can close this issue |
fryorcraken
pushed a commit
to fryorcraken/js-libp2p-gossipsub
that referenced
this issue
Aug 2, 2022
Added a time cache and a topic mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the message cache implementation is stable and fully tests (e.g when #3 is complete), it makes sense to refactor it into its own npm module. Several of these data structures that were created for libp2p such as the time cache have their own modules and are widely used for different projects.
The text was updated successfully, but these errors were encountered: