Skip to content

Create an npm module for message cache #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mikerah opened this issue Jan 11, 2019 · 3 comments
Closed

Create an npm module for message cache #5

Mikerah opened this issue Jan 11, 2019 · 3 comments

Comments

@Mikerah
Copy link
Contributor

Mikerah commented Jan 11, 2019

When the message cache implementation is stable and fully tests (e.g when #3 is complete), it makes sense to refactor it into its own npm module. Several of these data structures that were created for libp2p such as the time cache have their own modules and are widely used for different projects.

@GregTheGreek
Copy link
Member

Is this relevant?

@Mikerah
Copy link
Contributor Author

Mikerah commented Jun 25, 2019

Maybe not. But, the message cache is it's own data structure just like the time cache is. The time cache is used throughout js-libp2p projects. I'm not sure if the message cache is as extensively used.

@vasco-santos
Copy link
Collaborator

I would suggest that if we create a new module that needs a message cache, we extract it from here to its own module. Until then, we can close this issue

@Mikerah Mikerah closed this as completed Jun 25, 2019
fryorcraken pushed a commit to fryorcraken/js-libp2p-gossipsub that referenced this issue Aug 2, 2022
Added a time cache and a topic mapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants