fix!: remove @libp2p/components #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates all `@libp2p/*` deps to the latest versions and configures dependabot - for some reason it wasn't turned on for dev deps. BREAKING CHANGE: updates @libp2p/components to the latest major
|
The latest |
|
@wemeetagain looks like the e2e test timed out in CI? |
`@libp2p/components` is a choke-point for our dependency graph as it depends on every interface, meaning when one interface revs a major `@libp2p/components` major has to change too which means every module depending on it also needs a major. Switch instead to constructor injection of simple objects that let modules declare their dependencies on interfaces directly instead of indirectly via `@libp2p/components` Refs libp2p/js-libp2p-components#6 BREAKING CHANGE: modules no longer implement `Initializable` instead switching to constructor injection
achingbrain
changed the title
dapplion
reviewed
Oct 14, 2022
| @@ -361,7 +375,7 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements Initiali | |||
| cancel: () => void | |||
| } | null = null | |||
|
|
|||
| constructor(options: Partial<GossipsubOpts> = {}) { | |||
| constructor(components: GossipSubComponents, options: Partial<GossipsubOpts> = {}) { | |||
There was a problem hiding this comment.
This is a breaking change?
There was a problem hiding this comment.
Yeah, as noted in the PR title & description
dapplion
previously approved these changes
Oct 14, 2022
wemeetagain
approved these changes
Oct 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@libp2p/componentsis a choke-point for our dependency graph as it depends on every interface, meaning when one interface revs a major@libp2p/componentsmajor has to change too which means every module depending on it also needs a major.Switch instead to constructor injection of simple objects that let modules declare their dependencies on interfaces directly instead of
indirectly via
@libp2p/componentsRefs libp2p/js-libp2p-components#6
BREAKING CHANGE: modules no longer implement
Initializableinstead switching to constructor injection