fix(deps)!: Upgrade node/npm engine spec #524
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The engine spec applied here matches the minimum requirements of all transient dependencies (in `package-lock.json`). The engine requirement is changed from `npm` version to `node` version to better match with the engine spec discovered as outlined in the install attempts below (nobody seems to depend on npm versions, only node version). With `engine-strict=true` in `.npmrc`, I attempted to install with old versions of node/npm, until successfully installed and tested. Minimum spec install attempt ChainSafe#1: ``` $ nvm install v18.1.0 v18.1.0 is already installed. Now using node v18.1.0 (npm v8.8.0) $ npm install npm ERR! code EBADENGINE npm ERR! engine Unsupported engine npm ERR! engine Not compatible with your version of node/npm: @semantic-release/[email protected] npm ERR! notsup Not compatible with your version of node/npm: @semantic-release/[email protected] npm ERR! notsup Required: {"node":">=20.8.1"} npm ERR! notsup Actual: {"npm":"8.8.0","node":"v18.1.0"} ``` Minimum spec install attempt ChainSafe#2: ``` $ nvm install v20.8.1 v20.8.1 is already installed. Now using node v20.8.1 (npm v10.1.0) $ npm install npm ERR! code EBADENGINE npm ERR! engine Unsupported engine npm ERR! engine Not compatible with your version of node/npm: [email protected] npm ERR! notsup Not compatible with your version of node/npm: [email protected] npm ERR! notsup Required: {"node":"^18.18.0 || ^20.9.0 || >=21.1.0"} npm ERR! notsup Actual: {"npm":"10.1.0","node":"v20.8.1"} ``` Minimum spec install attempt ChainSafe#3: ``` $ nvm install v20.9.0 v20.9.0 is already installed. Now using node v20.9.0 (npm v10.1.0) $ npm install npm WARN deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported > @chainsafe/[email protected] prepare > npm run build > @chainsafe/[email protected] build > aegir build [10:23:50] tsc [started] [10:23:52] tsc [completed] [10:23:52] esbuild [started] [10:23:52] esbuild [completed] added 219 packages, removed 312 packages, changed 607 packages, and audited 1896 packages in 14s 363 packages are looking for funding run `npm fund` for details 17 vulnerabilities (16 moderate, 1 high) To address issues that do not require attention, run: npm audit fix To address all issues possible (including breaking changes), run: npm audit fix --force Some issues need review, and may require choosing a different dependency. Run `npm audit` for details. ``` BREAKING CHANGE: Requires Node v20.9.0 or newer
|
I'm aware that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine spec applied here matches the minimum requirements of all transient dependencies (in
package-lock.json). The engine requirement is changed fromnpmversion tonodeversion to better match with the engine spec discovered as outlined in the install attempts below (nobody seems to depend on npm versions, only node version).With
engine-strict=truein.npmrc, I attempted to install with old versions of node/npm, until successfully installed and tested.Minimum spec install attempt 1:
Minimum spec install attempt 2:
Minimum spec install attempt 3:
BREAKING CHANGE: Requires Node v20.9.0 or newer