Skip to content

Added support for interfaces implement interfaces to the type system. #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 4, 2020
Merged

Added support for interfaces implement interfaces to the type system. #1638

merged 17 commits into from
Apr 4, 2020

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Apr 2, 2020 •
edited
Loading

This PR brings support to the type system for interfaces implement interfaces: #703

  • Integrate into type system
  • type system tests
  • update introspection
  • introspection tests
  • sdl first support
  • sdl first tests

@michaelstaib michaelstaib requested a review from PascalSenn April 2, 2020 22:50
@michaelstaib michaelstaib self-assigned this Apr 2, 2020
@michaelstaib michaelstaib added 🌶 hot chocolate ⚖️ spec Implement or fix a GraphQL specification item. labels Apr 2, 2020
@michaelstaib michaelstaib added this to the HC-11.0.0 milestone Apr 2, 2020
@michaelstaib michaelstaib changed the title Added support for interfaces implement interfaces to the type system. WIP: Added support for interfaces implement interfaces to the type system. Apr 2, 2020
@michaelstaib
Copy link
Member Author

michaelstaib commented Apr 3, 2020 •
edited
Loading

@michaelstaib michaelstaib linked an issue Apr 3, 2020 that may be closed by this pull request
nullable inference of lists not accurate in PCF #1600
Closed
@michaelstaib michaelstaib mentioned this pull request Apr 3, 2020
Closed
@michaelstaib michaelstaib changed the title WIP: Added support for interfaces implement interfaces to the type system. Added support for interfaces implement interfaces to the type system. Apr 4, 2020
@michaelstaib michaelstaib merged commit 9dc88dc into master Apr 4, 2020
@michaelstaib michaelstaib deleted the interfaces branch April 4, 2020 20:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalSenn PascalSenn Awaiting requested review from PascalSenn

Assignees

@michaelstaib michaelstaib

Labels
⚖️ spec Implement or fix a GraphQL specification item.
Projects
None yet
Milestone
HC-11.0.0
Development

Successfully merging this pull request may close these issues.

nullable inference of lists not accurate in PCF
1 participant
@michaelstaib