-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CodeEditUI
: Added snapshot tests & Keep CircleCI?
#482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeEditUI
: Added snapshot tests & Keep CircleCI?
#482
Conversation
According to a google search CircleCI has some problems with rendering color correctly in snapshots. Maybe because they use VMs and not dedicated machines. The snapshot tests run perfectly on our Mac mini runner as well as locally (did 1000 repetitions without a failure). We might want to disable the test workflow on CircleCI temporarily (keep lint) until we figure out a way to run snapshot tests reliably. We should be able to run snapshot tests. Thoughts? @austincondiff @MarcoCarnevali @wdg @nanashili pointfreeco/swift-snapshot-testing#313 |
# Conflicts: # CodeEdit/Info.plist
CodeEditUI
: Added snapshot testsCodeEditUI
: Added snapshot tests & Keep CircleCI?
Can we test in black and white for the snapshots? |
Doesn't matter when the color is darker/brighter. It will still be different in greyscale. Also it works on our Mac mini runner just fine without any problems and faster too! |
# Conflicts: # CodeEdit/Info.plist
I just had a conversation with @MarcoCarnevali and we decided that for now we will exclude the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added snapshot tests for
CodeEditUI
componentsEffectView
,FontPickerView
,HelpButton
&SegmentedControl
Checklist