Skip to content

Don't Try to Set a Negative Frame Height #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thecoolwinter
Copy link
Contributor

Description

Fixes a potential recursion where CETV tries to set it's frame to a negative number (due to overscroll & scroll inset weirdness). This adds a super simple sanity check to make sure we limit the textview to a 0 frame at minimum.

This hang would occur when no content is present, making the content size an odd number, which also makes scroll views freak out on macOS.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A, fixes a hang.

@thecoolwinter thecoolwinter merged commit d51f3ad into CodeEditApp:main May 27, 2025
2 checks passed
@thecoolwinter thecoolwinter added the bug Something isn't working label May 27, 2025
@thecoolwinter thecoolwinter deleted the fix/frame-height-sanity-check branch May 27, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant