Skip to content

Add "static analysis" Composer keyword #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

GaryJones
Copy link
Contributor

As per https://getcomposer.org/doc/04-schema.md#keywords by including "static analysis" as a keyword in the composer.json file, Composer 2.4.0-RC1 and later will prompt users if the package is installed with composer require instead of composer require --dev. See composer/composer#10960 for more info.

The "phpcs" keyword is to match other coding-standards packages.

As per https://getcomposer.org/doc/04-schema.md#keywords by including "static analysis" as a keyword in the `composer.json` file, Composer 2.4.0-RC1 and later will prompt users if the package is installed with `composer require` instead of `composer require --dev`. See composer/composer#10960 for more info.

The "phpcs" keyword is to match other coding-standards packages.
@GaryJones
Copy link
Contributor Author

The Unit Tests workflow appears to have been broken since about 6 months ago, so doesn't seem related to the composer.json keyword change in this PR.

@MGatner
Copy link
Member

MGatner commented Sep 5, 2022

Thanks @GaryJones! Very cool new feature. I see you've spent a lot of effort on this across many repos: thanks for that effort. I will take this to the team and make sure we get it handled - we have a number of other repos that would benefit.

@paulbalandan paulbalandan merged commit cf22f6d into CodeIgniter:develop Sep 7, 2022
@paulbalandan
Copy link
Collaborator

Thank you, @GaryJones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants