Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] SQL Math Functions ASIN #2264

Closed
3 tasks done
codecademy-docs opened this issue May 26, 2023 · 14 comments · Fixed by #2582
Closed
3 tasks done

[Term Entry] SQL Math Functions ASIN #2264

codecademy-docs opened this issue May 26, 2023 · 14 comments · Fixed by #2582
Assignees
Labels
claimed Issue is claimed and closed to further assignment good first issue Good for newcomers new entry New entry or entries sql SQL entries

Comments

@codecademy-docs
Copy link
Collaborator

codecademy-docs commented May 26, 2023

Reason/inspiration (optional)

We would like a new term entry for the Math Function, ASIN, in SQL.

The entry should go in a file in docs/content/sql/concepts/math-functions/terms/asin/asin.md

The entry should:

  • Explain what the math function ASIN is in SQL and what it’s used for, starting with an introductory paragraph (2-3 sentences).
  • Include SQL database compatibility as a note.
  • Links out to entries as needed.

Please refer to the entry templates (term entry template in particular), content standards, and markdown style guide when working on the PR for this issue.

Entry Type (select all that apply)

New Term for Existing Concept Entry

Code of Conduct

  • By submitting this issue, I agree to follow Codecademy Doc's Code of Conduct.

For Maintainers

  • Labels added
  • Issue is assigned
@codecademy-docs codecademy-docs added new entry New entry or entries sql SQL entries good first issue Good for newcomers labels May 26, 2023
@Soura-2002
Copy link

i have to work

@SSwiniarski
Copy link
Contributor

@Soura-2002 are you asking to be assigned this issue?

@arisdelacruz
Copy link
Contributor

Can I be given the chance to work on this? Thanks.

@SSwiniarski
Copy link
Contributor

@arisdelacruz You're assigned! You can check out the Contribution Guide for additional information on contributing.
See Content Standards for an overview of styling tips that the Style Guide covers in detail.
After creating a PR, maintainer(s) (with the collaborator label) will add in comments/suggestions to address any revisions prior to approving.

In addition, please head over to the Docs Forum if you have any questions about Docs or reply to the thread on Possible Content Discussion to share ideas and collaborate with other contributors, maintainers, or super users to determine good future issues that will help expand Docs!

If this is your first time contributing, can you let us know how you came across this repo?

@SSwiniarski SSwiniarski added the claimed Issue is claimed and closed to further assignment label Jun 20, 2023
@arisdelacruz
Copy link
Contributor

@SSwiniarski

Yes, hello. Good day. Thank you for giving me the opportunity to work on this term entry.

I am currently finishing the Learn Git & Github course and I saw this one that it is not yet claimed 'til now and since this is one of the requirements in the Collaborating with the GitHub Community portion, I told myself to might as well give it a shot.

I hope you can accommodate my questions from time to time as I go along.

Thank you.

@arisdelacruz
Copy link
Contributor

github_entry

am i on the right track?

thanks

@SSwiniarski
Copy link
Contributor

SSwiniarski commented Jun 21, 2023

Looks good. Note that the note about compatibility with various DBMSs has been put at the end in most of the SQL math functions so far. (Like this one) It's not something we mandated, but thought you should know if you wanted consistency with other entries.

@arisdelacruz
Copy link
Contributor

duly noted on your advice

will revise accordingly

big thanks

@arisdelacruz
Copy link
Contributor

hi. i wonder what am i doing wrong

i keep receiving this in VS:

fatal: unable to access 'https://github.com/Codecademy/docs.git/': Failed to connect to github.com port 443 after
21190 ms: Couldn't connect to server

a helping hand on this is highly appreciated

thanks

@SSwiniarski
Copy link
Contributor

SSwiniarski commented Jun 23, 2023

@arisdelacruz Did you create your own fork for docs?

@arisdelacruz
Copy link
Contributor

Hello.

Yes, i have a copy of the repo on my github account

@SSwiniarski
Copy link
Contributor

@KTom101, @yangc95, @caupolicandiaz Any thoughts on what may be causing the problem?

@arisdelacruz
Copy link
Contributor

No further worries, guys.

I tried

git remote set-url origin

I am now in the pull request portion

I hope I'm still on the right track, hehe

Thanks, more power

@arisdelacruz
Copy link
Contributor

I just submitted a PR.

Crossing my fingers now, hehe

Thanks

@SSwiniarski SSwiniarski linked a pull request Jun 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimed Issue is claimed and closed to further assignment good first issue Good for newcomers new entry New entry or entries sql SQL entries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants