Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASIN() in sql #2582

Merged
merged 15 commits into from
Jun 28, 2023
Merged

ASIN() in sql #2582

merged 15 commits into from
Jun 28, 2023

Conversation

arisdelacruz
Copy link
Contributor

Description

I drafted, for review, a write-up on the ASIN() function in SQL when I was granted the permission to do it. Motivation emanates from the Codecademy lesson that I am currently taking on Github and its operations.

Type of Change

  • Adding a new entry

Checklist

  • [ / ] All writings are my own.
  • [ / ] My entry follows the Codecademy Docs style guide.
  • [ / ] My changes generate no new warnings.
  • [ / ] I have performed a self-review of my own writing and code.
  • [ / ] I have checked my entry and corrected any misspellings.
  • [ / ] I have made corresponding changes to the documentation if needed.
  • [ / ] I have confirmed my changes are not being pushed from my forked main branch.
  • [ / ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [ / ] Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2023

CLA assistant check
All committers have signed the CLA.

@SSwiniarski SSwiniarski linked an issue Jun 24, 2023 that may be closed by this pull request
3 tasks
@SSwiniarski SSwiniarski self-assigned this Jun 24, 2023
@SSwiniarski SSwiniarski added sql SQL entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Jun 24, 2023
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arisdelacruz I did a first review and left a few comments.

@arisdelacruz
Copy link
Contributor Author

@arisdelacruz I did a first review and left a few comments.

@SSwiniarski big thanks

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arisdelacruz I did two minor edits and it looks good for a second review.

@arisdelacruz
Copy link
Contributor Author

@arisdelacruz I did two minor edits and it looks good for a second review.

@SSwiniarski big thanks again

Sorry, is there anything that I need to do from my end

pls advise, thanks

@SSwiniarski
Copy link
Contributor

@arisdelacruz you don't need to do anything, just have some patience and another maintainer will come by and give this a second review.

@arisdelacruz
Copy link
Contributor Author

Noted this.

Big thanks

@caupolicandiaz caupolicandiaz added the status: under review Issue or PR is currently being reviewed label Jun 27, 2023
Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arisdelacruz @SSwiniarski I made a couple of minor edits. Looks good to merge.

@arisdelacruz
Copy link
Contributor Author

@arisdelacruz @SSwiniarski I made a couple of minor edits. Looks good to merge.

@SSwiniarski @caupolicandiaz big thanks, guys

@SSwiniarski SSwiniarski merged commit 7c530fe into Codecademy:main Jun 28, 2023
@github-actions
Copy link

👋 @arisdelacruz
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

@SSwiniarski
Copy link
Contributor

@arisdelacruz Congrats on the new entry! Live link here: https://www.codecademy.com/resources/docs/sql/math-functions/asin

image

You're currently anonymous. If you don't wish to be anonymous, check out this forum thread on how to link your GitHub and Codecademy profiles: https://discuss.codecademy.com/t/my-contribution-is-live-but-im-not-being-shown-as-a-contributor-why-is-this/758036 Note: it may take a few minutes for the change to register on the entry page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] SQL Math Functions ASIN
4 participants