-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add favicon html content #1418
add favicon html content #1418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@that-cisco-guy I did a first review and left a few comments. Most of the rephrasing is to avoid the direct address to the reader, which is not preferred in Docs.
I revised as per instruction but I'm not sure if I need to create a new pull request as I see my new commits at the end of the page. I apologize for the trouble, still getting Github down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@that-cisco-guy No need for a new PR. The edits will appear in this one. Looks good for a second review.
Thank you @SSwiniarski I appreciate your time. Is there anything else I need to do? I see some of the 'checks' failed; is that something I messed up and need to fix? |
@that-cisco-guy Running |
@yangc95 All the files are updated as requested. |
@yangc95 just checking in to see if there was anything else that needed to be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@that-cisco-guy Finished taking a look and left you some comments/suggestions 😄
|
||
Any image format that is supported by web browsers can be used as a favicon, but the most common format is `.ico`. An `.ico` file can be created using an image editor or online converter tool. | ||
|
||
With the favicon file and the `link` element in the HTML, the favicon should be displayed in the browser's address bar and tab title for the website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the favicon file and the
link
element in the HTML, the favicon should be displayed in the browser's address bar and tab title for the website.
This really depends on the browser being used. It seems that most modern browsers only display the favicon next to the tab title for the website whereas an HTTPS "lock icon" is next to the address bar.
Could we possibly rewrite this line as a new "## Example" section that describes this distinction with the following:
- An ```html code snippet with an image of the Codecademy logo as a favicon.
- A screenshot of what the rendered output would look like on the browser (including the HTTPS lock icon)
- Be sure to store this screenshot image in the
media/
folder and use the following format for the markdown image:https://raw.githubusercontent.com/Codecademy/docs/main/media/filename.ext
- Be sure to store this screenshot image in the
Co-authored-by: Brandon Dusch <[email protected]>
Co-authored-by: Brandon Dusch <[email protected]>
Co-authored-by: Brandon Dusch <[email protected]>
Co-authored-by: Brandon Dusch <[email protected]>
Co-authored-by: Brandon Dusch <[email protected]>
Co-authored-by: Brandon Dusch <[email protected]>
Co-authored-by: Brandon Dusch <[email protected]>
Co-authored-by: Brandon Dusch <[email protected]>
@Dusch4593 is no longer a maintainer on this repo.
@that-cisco-guy, because of over two weeks of inactivity, and in the interest of getting this merged, I implemented @Dusch4593's suggestions. |
👋 @that-cisco-guy |
Congrats @that-cisco-guy! Your entry is now live here: https://www.codecademy.com/resources/docs/html/favicon It looks like you're currently anonymous: |
Description
Added information on html favicon (shortcut image) to html content folder.
Type of Change
Checklist
main
branch.