refactor tutorial #115
Merged
refactor tutorial #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
niccokunzmann
commented
Mar 6, 2018
•
niccokunzmann
commented
- move js code from tutorial.html to js file Improve Footer #110
- use - in front of jekyll commands to remove white space Reduce page size by removing spaces #111
- remove test output of language tag Improve Footer #110
- remove jquery because the selected language is selected in jekyll Improve Footer #110
- move js code from tutorial.html to js file - use - in front of jekyll commands to remove white space - remove test output of language tag - remove jquery because the selected language is selected in jekyll
|
@niccokunzmann Everything looks great. Is there anything specific you needed me to do for this? |
|
@DaricusDuncan No, nothing specific. Thanks for having a look. Through pull requests we can spread knowledge and appreciation :) If you like, you can merge. |
|
I merged it to not forget it. Thanks for reviewing :) |
|
@niccokunzmann You are welcome. I forgot to respond back to you yesterday, but I did not have access to merge. The button to merge was not clickable. I should have told you sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.