Skip to content

fix: enforce full line to match when reference regex has the form ^...$ #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: enforce full line to match when reference regex has the form ^...$ #121

merged 1 commit into from
Apr 23, 2024

Conversation

moormaster
Copy link
Contributor

No description provided.

@moormaster moormaster mentioned this pull request Apr 21, 2024
Closed
2 tasks
@moormaster
Copy link
Contributor Author

Please also check if translations are ok - I don't speak sv nor pt-br :)

@niccokunzmann
Copy link
Member

I think, I cannot check the translations. But if someone from that language finds the translations misleading, they can open a new PR.

I only have this one question: #121 (comment)

@niccokunzmann
Copy link
Member

Thanks for the PR!

@moormaster moormaster force-pushed the fix-check-if-full-line-matches branch from 5b250f8 to 06da9c2 Compare April 22, 2024 17:03
@moormaster
Copy link
Contributor Author

force pushed:
added a small fix that ensured the overall result to not be "green" until every incomple match was fixed

@moormaster moormaster force-pushed the fix-check-if-full-line-matches branch from 06da9c2 to 3abcf4b Compare April 22, 2024 17:05
@niccokunzmann niccokunzmann merged commit ca83c21 into CoderDojoPotsdam:master Apr 23, 2024
@niccokunzmann
Copy link
Member

Thanks for all that work on the project! I will continue to help in that. Let me know if you need anything!

@moormaster moormaster deleted the fix-check-if-full-line-matches branch April 23, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niccokunzmann niccokunzmann niccokunzmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moormaster @niccokunzmann