Deprecated old gazetter View Generator. Also incremented minor version number. #244
Conversation
| @@ -47,6 +47,7 @@ | |||
| * | |||
| * @author Vivek Srikumar | |||
| */ | |||
| @Deprecated | |||
There was a problem hiding this comment.
Maybe add a comment that "instead of this you should use SimpleGazetteerAnnotator"?
| runTest(ta, fex); | ||
| } | ||
| } | ||
| // Not needed anymore, test of SimpleGazetteerAnnotator suffice. |
There was a problem hiding this comment.
Clarification: why these are not needed anymore?
|
@danyaljj ok, added more informative comments. |
| runTest(ta, fex); | ||
| } | ||
| } | ||
| // Not needed anymore, as test of SimpleGazetteerAnnotator in SimpleGazetteerAnnotatorTest.java suffice. |
There was a problem hiding this comment.
I think they are testing slightly different things. The test for SimpleGazetteerAnnotatorTest is testing its functionality directly. While this is testing correct functionality of SimpleGazetteerAnnotatorTest inside WordFeatureExtractorFactory.
What do you think?
There was a problem hiding this comment.
I dont know why Vivek did not separate the test class, but it is reasonable. After all, gazetteers are used for features right? The tests are checking the same feature, just the organization of the test code is different.
Still some commented out codes left for future reference. No need to test the old gazeetteer either.
Solves #146.