-
Notifications
You must be signed in to change notification settings - Fork 4
Warning no version #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The relevant commit really is this one: cc36480 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but needs some good testing on build-node.
The code looks fine but I have reservations about the digit-based approach. Some packages (e.g. GROMACS) have versions with an inconsistent the number of components/digits (e.g. 2023 and 2023.1 but no 2023.0), others have date-based versions (e.g. LAMMPS 20220623) where “one digit” is a bit unclear (it could be misunderstood to mean “2” rather than “20220623”). I think it would be better to special-case individual packages for which we want a different message. Or, make two lists: packages that follow semantic versioning (e.g. Python, Arrow) and those that do not. Packages that follow semver are the only ones for which I think it is helpful to not use a full version number (and the right number of components/digits for semver-following packages is always 2, major.minor). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, will need good testing
This pull request is a proposal to address ComputeCanada/software-stack#122