Submodules #39
Submodules #39
Conversation
|
+1 on the code, tests need some adjustment though - we should add existing common-steps/common-steps before we do |
|
|
|
|
|
|
|
|
1 similar comment
|
|
|
|
|
|
had to remove sanity check(probably is better to move it to some subcommand), because there should not been some features/steps defined in time it is run
|
@vrutkovs fixed tests and added common steps back. |
|
|
|
|
| else: | ||
| logger.info("Adding tests/features/common-features as a submodule") | ||
| check_call('git submodule add https://github.com/Containers-Testing-Framework/common-features.git tests/features/common-features', shell=True) | ||
|
|
||
| common_steps_dir = os.path.join(steps_dir, "common_steps") | ||
| if os.path.exists(common_steps_dir): | ||
| logger.info("Directory tests/steps/common_steps already exists") | ||
| else: | ||
| logger.info("Adding tests/steps/common_steps as a submodule") | ||
| check_call('git submodule add https://github.com/Containers-Testing-Framework/common-steps.git tests/steps/common_steps', shell=True) |
There was a problem hiding this comment.
We shouldn't forcibly add common-steps here
|
hmm I cant do that easily because python doesn't like - character in imports it seems. so if I add common-steps this way. it dies. |
|
|
|
Alternatively we can add a submodule with a new name (stripping non-alphanumeric chars) |
|
@vrutkovs Ok.. will update it in _write_environment_py. you ar right its better solution |
|
|
reopening #31 against master