Skip to content

all actors on a train can now be controlled with one single contraption controll #8289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ProgrammerLP
Copy link

Bildschirmaufzeichnung.vom.2025-04-18.14-49-48.mp4

@VoidLeech VoidLeech added pr type: feature PR adds a new feature or changes an existing feature pr flag: simple PR has minimal changes labels Apr 18, 2025
@techno-sam
Copy link
Contributor

techno-sam commented May 18, 2025

It looks like this is not configurable per-control. There are certainly instances where this would not be optimal behaviour - for example, I might have a long trackbed-laying train, and have different carriages for different materials that I could activate separately.

It might be best either to have a separate (brass-themed?) contraption controls block for this feature, or to carefully consider which actors should be train-global and which should be carriage-local (though this may introduce significant confusion).

simibubi added a commit that referenced this pull request May 19, 2025
- Contraption controls with a door as their target now affect all carriages of a train #8289
@simibubi
Copy link
Collaborator

Thanks for the PR.
I agree with sam, there are cases where separated controls are helpful.
Doors are now special cased to behave like this, though. That should cover the use case you presented

@simibubi simibubi closed this May 19, 2025
@ProgrammerLP
Copy link
Author

Nice that doors are now special cases, but i think a seperated control for this would be nice, because there are also use case to control things over the entire train. So should i add these in a new pr? An other solution would be a tag, all controllable actors with a specific tag will be controlled over the entire train?

@ProgrammerLP
Copy link
Author

Because in my addon there will be new blocks which should also be able to control on all carriages

@simibubi
Copy link
Collaborator

Changing it to tag-based is more likely to get merged than a second version of the contraption controls

@ProgrammerLP
Copy link
Author

Ok, thanks, I will try a tag based system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr flag: simple PR has minimal changes pr type: feature PR adds a new feature or changes an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants