Skip to content

Make Peculiar Bell Transformation Pull from Haunting Catalyst Tag #8376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: mc1.20.1/dev
Choose a base branch
from
Open

Make Peculiar Bell Transformation Pull from Haunting Catalyst Tag #8376

wants to merge 8 commits into from

Conversation

Attack8
Copy link
Contributor

@Attack8 Attack8 commented Apr 29, 2025

@VoidLeech VoidLeech added pr type: feature PR adds a new feature or changes an existing feature pr flag: simple PR has minimal changes labels Apr 29, 2025
@VoidLeech
Copy link
Collaborator

How does this interact with the blaze burner?

@RaymondBlaze
Copy link
Contributor

How does this interact with the blaze burner?

Definitely not properly handled.

I would suggest using HauntingType#isValidAt directly since it properly handles both fluid and blocks, including lit blaze burner and modded state-specific blocks (either already supported by Create or supported by the mod itself by mixin into Create).

@Attack8
Copy link
Contributor Author

Attack8 commented May 14, 2025

How does this interact with the blaze burner?

Definitely not properly handled.

I would suggest using HauntingType#isValidAt directly since it properly handles both fluid and blocks, including lit blaze burner and modded state-specific blocks (either already supported by Create or supported by the mod itself by mixin into Create).

Thanks for the feedback. I changed it to use HauntingType#isValidAt as you suggested

@Attack8 Attack8 requested a review from RaymondBlaze May 15, 2025 00:51
IThundxr
IThundxr requested changes May 19, 2025
View reviewed changes
@Attack8 @IThundxr
Commit Suggestion
5c33ac5 
Co-authored-by: IThundxr <[email protected]>
@Attack8 Attack8 requested a review from IThundxr May 26, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaymondBlaze RaymondBlaze RaymondBlaze approved these changes

@IThundxr IThundxr Awaiting requested review from IThundxr

Assignees
No one assigned
Labels
pr flag: simple PR has minimal changes pr type: feature PR adds a new feature or changes an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Attack8 @VoidLeech @RaymondBlaze @IThundxr