Fix helm image.repository to include image name

[ron1]

Fix helm image.repository to include image name to be consistent with relatedImages.*.repository which already includes image name. This change also allows the postgres-operator image name to be overridden which is a secondary benefit.

[jkatz]

@ron1 Can you please provide an example?

[ron1]

For example, relatedImages.postgres_13.repository value registry.developers.crunchydata.com/crunchydata/crunchy-postgres-ha includes image name crunchy-postgres-ha. But image.repository value registry.developers.crunchydata.com/crunchydata is missing image name postgres-operator. In this case, the image name is appended to image.repository value here:

postgres-operator-examples/helm/install/templates/manager.yaml

Line 20 in 4af6f57

image: "{{ .Values.image.repository }}/postgres-operator:{{ .Values.image.tag }}"

.

So, for related images, the helm repository value includes the image name but for the operator image, its helm repository value excludes the image name.

A simple fix would be to remove string /postgres-operator from line

postgres-operator-examples/helm/install/templates/manager.yaml

Line 20 in 4af6f57

image: "{{ .Values.image.repository }}/postgres-operator:{{ .Values.image.tag }}"

and append string /postgres-operator to line

postgres-operator-examples/helm/install/values.yaml

Line 4 in 4af6f57

repository: registry.developers.crunchydata.com/crunchydata

.

Does that make sense?

[jkatz]

@ron1 Yup that makes sense. That seems reasonable to do.

[ron1]

@jkatz This issue is a bit orthogonal to the "related images" format and your "related images" patch which closed this issue. Instead, this issue focuses exclusively on the "postgres-operator" image format.

Currently, this chart hard-codes the image name to be "postgres-operator". I want the ability to change its image name to say "mirrored-postgres-operator" following the pattern Rancher uses when they bundle a third-party image with their product. An example of this Rancher approach is available here: https://github.com/rancher/rancher/releases/download/v2.5.11/rancher-images.txt.

Please consider re-opening this issue and applying the changes I proposed above.

Thanks.

[jkatz]

@ron1 Got it. That should be fairly easy to tackle.

[ron1]

@jkatz Perfect! Thanks much!