Require At Least One Repo to be Configured #2662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlecuyer
force-pushed
the
repo-validation
branch
from
5339b47 to
4328c11
Compare
andrewlecuyer
changed the title
At least one pgBackRest repository must be defined within a PostgresCluster spec for the proper operation of any/all PostgreSQL clusters created by PGO. This commit therefore updates the validation for the "repos" section of the spec to require that at least one repo always be defined when creating or modifying a PostgresCluster. Issue: [ch12418]
andrewlecuyer
force-pushed
the
repo-validation
branch
from
4328c11 to
c0fcb04
Compare
tjmoore4
approved these changes
Sep 8, 2021
cbandy
approved these changes
Sep 8, 2021
|
I'm not sure this was the correct fix: why should I have to have a repo configured if I don't want backups?
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one pgBackRest repository must be defined within a PostgresCluster spec for the proper operation of any/all PostgreSQL clusters created by PGO.
This commit therefore updates the validation for the
repossection of the spec to require that at least one repo alwaysbe defined when creating or modifying a PostgresCluster.
[ch12418]