Optional backups v2 #3977
Merged
Optional backups v2 #3977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2915,3 +3007,92 @@ func (r *Reconciler) reconcilePGBackRestCronJob( | |||
| } | |||
| return err | |||
| } | |||
|
|
|||
| // BackupsEnabled checks the state of the backups (i.e., if backups are in the spec, | |||
| // if a repo-host StatefulSet exists, if the annotation permitting backup deletion exist) | |||
There was a problem hiding this comment.
Suggested change
| // if a repo-host StatefulSet exists, if the annotation permitting backup deletion exist) | |
| // if a repo-host StatefulSet exists, if the annotation permitting backup deletion exists) |
benjaminjb
commented
Aug 26, 2024
| @@ -382,6 +439,24 @@ func unstructuredToRepoResources(kind string, repoResources *RepoResources, | |||
| uList *unstructured.UnstructuredList) error { | |||
|
|
|||
| switch kind { | |||
There was a problem hiding this comment.
There's several changes here because I reordered these cases to match the order of the list where we get these items (in getPGBackRestResources).
benjaminjb
commented
Aug 26, 2024
| @@ -343,6 +394,12 @@ func (r *Reconciler) cleanupRepoResources(ctx context.Context, | |||
| ownedNoDelete = append(ownedNoDelete, owned) | |||
| delete = false | |||
| } | |||
| case hasLabel(naming.LabelPGBackRest): | |||
There was a problem hiding this comment.
Adding this to take care of RBAC and other items not caught by the previous cases.
tony-landreth
approved these changes
Aug 27, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Backups are required
What is the new behavior (if this is a feature change)?
Backups are optional
Other Information:
Issues: [PGO-1529]