Skip to content

Speed up KUTTL tests by dropping backups #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Speed up KUTTL tests by dropping backups #3982

merged 2 commits into from
Sep 6, 2024

Conversation

benjaminjb
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:
Issues: [PGO-1572]

@@ -12,9 +12,3 @@ spec:
instances:
- replicas: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test run slower when backups are off and replicas > 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I see four tests that have replicas and need them, so I'm testing them out:

  • replica-read
    • w/ backups: ~28s
    • w/o backups:~25s
  • scaledown
    • w/ backups: ~2m
    • w/o backups:~3m
  • switchover
    • w/ backups: ~37s
    • w/o backups:~34s

So adding backups back to Scaledown files for now and testing.

@benjaminjb
Copy link
Contributor Author

benjaminjb commented Aug 30, 2024

Optional backups PR with new KUTTL test:
Screenshot 2024-08-30 at 11 59 35 AM

KUTTL tests trimmed to avoid backups
Screenshot 2024-08-30 at 11 59 44 AM

And after a few tweaks to the tests:
Screenshot 2024-08-30 at 2 08 12 PM

@benjaminjb benjaminjb merged commit e1c1b00 into master Sep 6, 2024
13 checks passed
@benjaminjb benjaminjb deleted the speed-up-kuttl branch September 6, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants