Skip to content

Otel custom queries #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Otel custom queries #4126

merged 1 commit into from
Mar 11, 2025

Conversation

dsessler7
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

No way to customize queries for metrics when using OTel feature.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

You can now both provide custom queries/metrics and turn off existing ones when using the OpenTelemetryMetrics feature.

Other Information:

@dsessler7 dsessler7 force-pushed the otel-custom-queries branch from ee1434b to 7bc0c03 Compare March 10, 2025 23:43
@dsessler7 dsessler7 requested a review from benjaminjb March 11, 2025 02:11
@dsessler7 dsessler7 requested a review from benjaminjb March 11, 2025 18:57
benjaminjb
benjaminjb approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and just double checking -- all the pods/custom query behavior still works, yeah?

@dsessler7
Copy link
Contributor Author

Ha, yup! Everything still works.

@dsessler7
Custom queries for metrics via OTel:
f57e04d 
* Add section for metrics collection configuration to instrumentation API
* Add provided custom queries file(s) to the config volume and create a new sqlquery receiver
* Remove specified metrics from the default metrics; if all metrics for a given query are removed, remove the query as well
* Add a collector label for discovery purposes
@dsessler7 dsessler7 force-pushed the otel-custom-queries branch from b4430fc to f57e04d Compare March 11, 2025 20:22
@dsessler7 dsessler7 enabled auto-merge (rebase) March 11, 2025 20:24
@dsessler7 dsessler7 merged commit f2ec29d into CrunchyData:main Mar 11, 2025
19 checks passed
@dsessler7 dsessler7 deleted the otel-custom-queries branch March 11, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjb benjaminjb benjaminjb approved these changes

@cbandy cbandy Awaiting requested review from cbandy

@tony-landreth tony-landreth Awaiting requested review from tony-landreth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsessler7 @benjaminjb