-
-
Notifications
You must be signed in to change notification settings - Fork 13
feat: detect simplified repositories from package.json
like structures
#517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@lal12 you are right, there is missing a feature to do the needed repository transformations. As the original request was a bug report in https://github.com/CycloneDX/cyclonedx-webpack-plugin/ justification / case / context current implementation simply applies the "repository", and does not do the simplified-repository-rules that package managers know about.
read https://github.com/npm/normalize-package-data |
package.json
like structures
@lal12 are you willing to contribute the missing feature based on #517 (comment)? if so, then please follow the guidelines: https://github.com/CycloneDX/cyclonedx-javascript-library/blob/main/CONTRIBUTING.md
PS: there is not no actual need for action. I will implement a fix in the downstream implementations that do the needed normalization. |
The solution will not be to implement the needed normalization here, |
The package https://github.com/vercel/ms / https://www.npmjs.com/package/ms specifies
"repository": "vercel/ms"
.The npm website and cli utility interprets this as a relative url to github.
The SBOM includes the
vcs_url
asvercel/ms
. So I wonder ifhttps://github.com
should be prepended in such cases? Maybe with an option to specify a default URL to prepend?The text was updated successfully, but these errors were encountered: