Skip to content

feat: NodeJS exports submodules as subpaths #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 14, 2024
Merged

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented May 13, 2024

fixes #87

Added

  • Explicitly export own first-level submodules via package manifest (via #1066)
    When used with bundlers/packers downstream, this might enable better tree shaking due to scoped imports.

Refactor

  • Ease internal tree shaking (via #1066)

@jkowalleck jkowalleck added the enhancement New feature or request label May 13, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner May 13, 2024 10:12
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Copy link

codacy-production bot commented May 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (07cb79f) 22788 22377 98.20%
Head commit (7dcdb71) 22902 (+114) 22491 (+114) 98.21% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1066) 147 147 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck changed the title feat: NodeJS exports sub-modules as path-like feat: NodeJS exports submodules as subpaths May 14, 2024
@jkowalleck jkowalleck merged commit 19a6a49 into main May 14, 2024
43 checks passed
@jkowalleck jkowalleck deleted the feat/exports-submodules branch May 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support package "exports"
1 participant