-
-
Notifications
You must be signed in to change notification settings - Fork 13
tsconfig: default esModuleInterop
& allowSyntheticDefaultImports
#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enables projects that use this library to also have esModuleInterop set to false (which is the more strict options), improving ease of use. Signed-off-by: Craig Andrews <[email protected]>
5b92635
to
1b04911
Compare
Signed-off-by: Jan Kowalleck <[email protected]>
esModuleInterop
& allowSyntheticDefaultImports
I modified the original change request from @candrews so that now the tsconfig default value is used, |
thanks for the improvement, @candrews . |
I got the impression, that you are running your own webpack process on the source code of this project. Or is this not because of recompiling but usage of a TypeScript code that uses Some background: I want to incorporate a better SPDX license expression validation process. Therefore, I wanted to utilize a module which requires |
Caused by #271 Might need to reopen this, to get https://www.npmjs.com/package/spdx-expression-parse in Having So the new code would revert this PR. :-/ |
I'm using it in my fork of Snyk CLI that generates CycloneDX SBOMs: https://github.com/candrews/snyk-cli Here's the PR to the Snyk project which shows exactly the changes in my fork: snyk/cli#3983 This library is imported using: |
Ah, I remember. Thanks. So all good, as long as the type declarations consumed downstream do not require |
Enables projects that use this library to also have esModuleInterop set to false (which is the more strict options), improving ease of use.