Skip to content

Serial number #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Serial number #597

merged 5 commits into from
Mar 28, 2023

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Mar 28, 2023

fixes #588


  • Fixed
    • "Bom.serialNumber" data model can have values following the alternative format allowed in CycloneDX XML specification
    • Serialize.{JSON,XML}.Normalize.BomNormalizer.normalize now omits invalid/unsupported values for serialNumber
  • Changed
    • Property Models.Bom.serialNumber is of type string, was type-aliased Types.UrnUuid = string
      Also the setter no longer throws exceptions, since no string format is illegal.
      This is considered a non-breaking behaviour change, because the corresponding normalizers assure valid data results.
  • Added
    • Bom serialNumber generator: Utils.BomUtility.randomSerialNumber()
  • deprecated
    • Type alias Types.UrnUuid = string became deprecated
      Use type string instead.
    • Function Types.isUrnUuid became deprecated

Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck added bug Something isn't working enhancement New feature or request labels Mar 28, 2023
@jkowalleck jkowalleck requested a review from a team as a code owner March 28, 2023 13:03
@codacy-production
Copy link

Coverage summary from Codacy

Merging #597 (10438aa) into main (3158763) - See PR on Codacy

Coverage variation Diff coverage
Report missing for 31587631 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3158763) Report Missing Report Missing Report Missing
Head commit (10438aa) 5269 5172 98.16%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#597) 89 89 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jkowalleck jkowalleck merged commit 37c29b8 into main Mar 28, 2023
@jkowalleck jkowalleck deleted the serialNumber branch March 28, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slacken Bom.serialNumber in data models
1 participant